New. BotDetectorService. Frontend data log. by alexander-b-clean · Pull Request #864 · CleanTalk/wordpress-antispam

alexander-b-clean · 2026-08-21T15:27:52Z

https://app.doboard.com/1/task/51081

Copilot

Pull request overview

This PR refactors bot-detector “frontend data log” collection/transfer into a consolidated browser state payload (apbct_browser_state) that is injected into frontend requests, then parsed server-side and exposed via apbct__bot_detector_get_fd_log(). It also updates AltSessions allow-listing and expands PHPUnit coverage for transport-specific state retrieval.

Changes:

Replace periodic “save log to AltSessions” JS with an ApbctBrowserState collector and request-injection (apbct_browser_state) across XHR/fetch/FormData/string bodies.
Update PHP to return apbct_browser_state (with defaults/error handling) and add helpers to parse state from RequestParameters/POST.
Expand standalone tests to cover AltSessions/NoCookie/POST transports and default-filling behavior.

Reviewed changes

Copilot reviewed 15 out of 23 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
tests/StandaloneFunctions/TestBotDetectorLogGathering.php	Reworked tests to validate new browser-state transport behavior and defaults.
lib/Cleantalk/ApbctWP/Variables/AltSessions.php	Allow-list `apbct_browser_state` as JSON in AltSessions validation.
js/src/public-3-bot-detector-log.js	Introduces `ApbctBrowserState` + `apbctGetBrowserStatePair()` for request injection.
js/src/public-1-main.js	Injects `apbct_browser_state` into multiple request interception paths (XHR/fetch/etc.).
js/src/public-1-functions.js	Includes browser state into NoCookie hidden-field payload / storage data array.
js/prebuild/apbct-public-bundle.js	Prebuilt bundle updated with browser state injection logic.
js/prebuild/apbct-public-bundle_int-protection.js	Prebuilt bundle updated with browser state injection logic.
js/prebuild/apbct-public-bundle_int-protection_gathering.js	Prebuilt bundle updated with browser state injection logic.
js/prebuild/apbct-public-bundle_gathering.js	Prebuilt bundle updated with browser state injection logic.
js/prebuild/apbct-public-bundle_full-protection.js	Prebuilt bundle updated with browser state injection logic.
js/prebuild/apbct-public-bundle_full-protection_gathering.js	Prebuilt bundle updated with browser state injection logic.
js/prebuild/apbct-public-bundle_ext-protection.js	Prebuilt bundle updated with browser state injection logic.
js/prebuild/apbct-public-bundle_ext-protection_gathering.js	Prebuilt bundle updated with browser state injection logic.
js/apbct-public-bundle.min.js	Minified public bundle updated to match new browser state behavior.
inc/cleantalk-common.php	Server-side browser state parsing + updated fd-log return structure.
cleantalk.php	Changes bot detector wrapper script URL constant.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

…ontend_data-logger.ab

# Conflicts: # js/apbct-public-bundle.min.js # js/apbct-public-bundle_ext-protection.min.js # js/apbct-public-bundle_ext-protection_gathering.min.js # js/apbct-public-bundle_full-protection.min.js # js/apbct-public-bundle_full-protection_gathering.min.js # js/apbct-public-bundle_gathering.min.js # js/apbct-public-bundle_int-protection.min.js # js/apbct-public-bundle_int-protection_gathering.min.js

Glomberg · 2026-08-24T05:54:55Z

Please, fix autotests first.

codecov · 2026-08-24T07:45:21Z

Codecov Report

❌ Patch coverage is 90.65421% with 10 lines in your changes missing coverage. Please review.
✅ Project coverage is 30.28%. Comparing base (f2102e1) to head (36484fd).

Files with missing lines	Patch %	Lines
lib/Cleantalk/ApbctWP/BotDetectorService.php	92.15%	8 Missing ⚠️
inc/cleantalk-common.php	50.00%	2 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##                dev     #864      +/-   ##
============================================
+ Coverage     30.00%   30.28%   +0.27%     
- Complexity     6539     6582      +43     
============================================
  Files           289      290       +1     
  Lines         26259    26306      +47     
============================================
+ Hits           7880     7966      +86     
+ Misses        18379    18340      -39

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

# Conflicts: # lib/Cleantalk/ApbctWP/Variables/AltSessions.php

Copilot

🟡 Changes recommended

There are verified functional issues in the new browser-state/log pipeline (PHP notice risk and inconsistent frontend log key/reader) plus several incorrect deprecation references that should be corrected before merge.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Review details

Suppressed comments (2)

lib/Cleantalk/ApbctWP/BotDetectorService.php:147

Method name isNoScripFlow() appears to be a typo (missing 't') while the doc refers to a "NoScript" flow. Since this is a new API surface and is referenced from a deprecated wrapper, consider introducing the correctly spelled isNoScriptFlow() and keeping the old name as a deprecated alias for backward compatibility.

    public static function isNoScripFlow()
    {
        if (apbct_is_plugin_active('oxygen/functions.php') && Get::getBool('ct_builder')) {
            return true;
        }

inc/cleantalk-common.php:1850

The @deprecated note for apbct__is_bot_detector_enabled() references BotDetectorService::enabled(), but the actual method is BotDetectorService::isEnabled(). This mismatch can mislead users and static analysis tools.

/**
 * Check if Bot-Detector is enabled/disabled
 * @deprecated since 6.88, use BotDetectorService::enabled() instead
 * @return bool
 */

Files reviewed: 18/26 changed files
Comments generated: 5
Review effort level: Lite

datorik added 2 commits August 20, 2026 18:05

Udp.Code. frontend_data logger

5a2df8e

Udp.Code. frontend_data logger fix

16f70c4

alexander-b-clean requested a lite review from Copilot August 21, 2026 15:27

Copilot started reviewing on behalf of alexander-b-clean August 21, 2026 15:28 View session

Copilot AI reviewed Aug 21, 2026

View reviewed changes

Comment thread cleantalk.php

Comment thread js/src/public-3-bot-detector-log.js

Comment thread inc/cleantalk-common.php Outdated

alexander-b-clean and others added 2 commits August 21, 2026 18:38

Potential fix for pull request finding

a7daff5

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Udp.Code. frontend_data logger fix. Code review

9de7a7f

alexander-b-clean requested review from AntonV1211 and Glomberg August 21, 2026 15:41

datorik added 2 commits August 21, 2026 18:45

Merge remote-tracking branch 'origin/frontend_data-logger.ab' into fr…

5d524ea

…ontend_data-logger.ab

Fix errors psalm

80501e9

AntonV1211 requested review from alexandergull and removed request for AntonV1211 August 24, 2026 12:42

Glomberg approved these changes Aug 24, 2026

View reviewed changes

alexandergull added 2 commits September 2, 2026 20:19

Merge branch 'dev' into frontend_data-logger.ab

7602cec

# Conflicts: # lib/Cleantalk/ApbctWP/Variables/AltSessions.php

Upd. BotDetectorService. FD log updates.

8346aa4

alexandergull changed the title ~~Udp.Code. frontend_data logger~~ New. BotDetectorService. Frontend data log. Sep 3, 2026

alexandergull requested a lite review from Copilot September 3, 2026 10:37

Copilot started reviewing on behalf of alexandergull September 3, 2026 10:38 View session

alexandergull approved these changes Sep 3, 2026

View reviewed changes

Copilot AI reviewed Sep 3, 2026

View reviewed changes

Comment thread js/src/public-3-bot-detector-log.js Outdated

Comment thread lib/Cleantalk/ApbctWP/BotDetectorService.php

Comment thread inc/cleantalk-common.php

Comment thread inc/cleantalk-public.php

Comment thread lib/Cleantalk/ApbctWP/BotDetectorService.php

alexandergull added 3 commits September 4, 2026 10:37

CP. Fixed default statement.

5d382b6

CP. Docblock updated.

50d9f80

CP. Cookie prefix added.

57db974

alexandergull requested a review from Glomberg September 4, 2026 05:52

Fix. Moderate url fixed.

36484fd

Navigation Menu

Uh oh!

New. BotDetectorService. Frontend data log. - #864

New. BotDetectorService. Frontend data log.#864
alexander-b-clean wants to merge 13 commits into
devfrom
frontend_data-logger.ab

alexander-b-clean commented Aug 21, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Glomberg commented Aug 24, 2026

Uh oh!

codecov Bot commented Aug 24, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Uh oh!

Conversation

alexander-b-clean commented Aug 21, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Glomberg commented Aug 24, 2026

Uh oh!

codecov Bot commented Aug 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🟡 Changes recommended

Suppressed comments (2)

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

codecov Bot commented Aug 24, 2026 •

edited

Loading